-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [fix: go/v3, go/v4] Remove stale imports #3270
🐛 [fix: go/v3, go/v4] Remove stale imports #3270
Conversation
This PR removes the stale import: "pkg/envtest/printer" that is not needed after migrating to ginko/v2. Controller-runtime v0.14.0+ has migrated to use ginko/v2 and thereby removed "printer" package. The imports were still being scaffolded though not used in the codebase. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, em-r, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick release-3.9 |
This PR removes the stale import: "pkg/envtest/printer" that is not needed after migrating to ginko/v2.
Controller-runtime v0.14.0+ has migrated to use ginko/v2 and thereby removed "printer" package. The imports were still being scaffolded though not used in the codebase.
This was causing the error mentioned here by one of the community users.